Merge pull request #16561 from davelopez/fix_install_tools_from_admin…

…_panel

Fix: serialize `tool_shed_urls` directly from the API

lib/galaxy/managers/configuration.py

@@ -233,5 +233,9 @@ def _defaults_to(default):
                 "user_library_import_dir": _defaults_to(None),
                 "allow_library_path_paste": _defaults_to(False),
                 "allow_user_deletion": _defaults_to(False),
+                "tool_shed_urls": self._serialize_tool_shed_urls,
             }
         )
+
+    def _serialize_tool_shed_urls(self, item: Any, key: str, **context) -> List[str]:
+        return list(self.app.tool_shed_registry.tool_sheds.values()) if self.app.tool_shed_registry else []

lib/galaxy/webapps/base/controller.py

@@ -300,9 +300,6 @@ def _get_extended_config(self, trans):
             "enable_webhooks": True if trans.app.webhooks_registry.webhooks else False,
             "message_box_visible": trans.app.config.message_box_visible,
             "show_inactivity_warning": trans.app.config.user_activation_on and trans.user and not trans.user.active,
-            "tool_shed_urls": list(trans.app.tool_shed_registry.tool_sheds.values())
-            if trans.app.tool_shed_registry
-            else [],
             "tool_dynamic_configs": list(trans.app.toolbox.dynamic_conf_filenames()),
         }
 

lib/galaxy_test/api/test_configuration.py

@@ -20,6 +20,7 @@
     "user_library_import_dir",
     "allow_library_path_paste",
     "allow_user_deletion",
+    "tool_shed_urls",
 ]