Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.1] Swap datatype&convert tab to a static 'datatypes' tab. #16466

Merged
merged 2 commits into from
Jul 26, 2023

Conversation

dannon
Copy link
Member

@dannon dannon commented Jul 26, 2023

This reduces user confusion -- all datatype related stuff is now in this one tab that is consistently named. Fixes #16151

I also reordered the form so that 'datatype' is first, followed by 'convert', since the latter is not always an option -- so stuff stays in a consistent order.

This could use some modernization, but let's target dev for that.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@dannon dannon marked this pull request as ready for review July 26, 2023 16:32
@github-actions github-actions bot added this to the 23.2 milestone Jul 26, 2023
…ser confusion -- all datatype related stuff is now in this one tab that is consistently named
@dannon dannon changed the title Swap datatype&convert tab to a static 'datatypes' tab. [23.1] Swap datatype&convert tab to a static 'datatypes' tab. Jul 26, 2023
@dannon dannon changed the base branch from dev to release_23.1 July 26, 2023 16:40
Co-authored-by: Marius van den Beek <m.vandenbeek@gmail.com>
@mvdbeek mvdbeek merged commit 437fe9c into galaxyproject:release_23.1 Jul 26, 2023
16 checks passed
@dannon dannon modified the milestones: 23.2, 23.1 Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

[UI] Unify "Convert" and "Datatypes" tabs in the edit attributes menu.
2 participants