Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Unify "Convert" and "Datatypes" tabs in the edit attributes menu. #16151

Closed
shiltemann opened this issue May 26, 2023 · 2 comments · Fixed by #16466
Closed

[UI] Unify "Convert" and "Datatypes" tabs in the edit attributes menu. #16151

shiltemann opened this issue May 26, 2023 · 2 comments · Fixed by #16466

Comments

@shiltemann
Copy link
Member

The procedure in the UI for changing the datatype is different depending on whether a conversion is possible for the dataset.

E.g. For some datasets you have to click on the "Convert" tab, and for datasets without conversions available the tab is named "Datatypes" tab. To me it would make more sense to always have this tab be "Datatypes", and letting that tab have a convert option or not depending on the datatype.

image

image

e.g. our FAQ for changing datatype says to click on the convert tab, but sometimes it is the Datatypes tab, and I think it would be easier for users to recognize if it's always the same name.

@hexylena
Copy link
Member

xref #5768, we have the space for the tabs, we could un-unify them. Or at least give it a unified title/icon, whether showing just datatype change, or datatype change + convert

@dannon
Copy link
Member

dannon commented May 26, 2023

I don't think we want to separate them again -- the problem before was that it was confusing to users why we had two tabs next to one another that did (at face value) similar things. I think we should probably just make the tab title static and more appropriate reflecting "Things related to the datatype here", as in the original issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

3 participants