Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect GRAVITY_STATE_DIR when activating venv #13685

Merged
merged 1 commit into from
Apr 7, 2022

Conversation

nsoranzo
Copy link
Member

@nsoranzo nsoranzo commented Apr 6, 2022

So that something like:

export GRAVITY_STATE_DIR=/srv/galaxy/gravity
./run.sh

writes gravity state/log files to the right place.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. Start Galaxy as mentioned above
    2. Check that gravity writes to the correct directory

License

So that:

export GRAVITY_STATE_DIR=/srv/galaxy/gravity
./run.sh

writes gravity state/log files to the right place.
@github-actions github-actions bot added this to the 22.05 milestone Apr 6, 2022
@mvdbeek mvdbeek merged commit 5935182 into galaxyproject:dev Apr 7, 2022
@nsoranzo nsoranzo deleted the respect_GRAVITY_STATE_DIR branch April 7, 2022 14:53
@mvdbeek
Copy link
Member

mvdbeek commented Apr 8, 2022

I suppose #13692 is the side effect of this change

@nsoranzo
Copy link
Member Author

nsoranzo commented Apr 8, 2022

run.sh doesn't leak GRAVITY_STATE_DIR into the environment, so I think it was manually set.

@jdavcs
Copy link
Member

jdavcs commented Apr 8, 2022

I suppose #13692 is the side effect of this change

Not this one, it's setting it in the venv's activate script: deactivating the venv won't unset it, so it persists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants