GRAVITY_STATE_DIR not respected when galaxy cloned into new location

[jdavcs]

Describe the bug
Installing a fresh clone to a new location (after having run galaxy from a different location) and running via run.sh will reuse the value of GRAVITY_STATE_DIR from previous installation.

Galaxy Version and/or server at which you observed the bug
Galaxy Version: dev
Commit: 308db49 (fresh dev)

To Reproduce

1. never run galaxy
2. clone galaxy into /foo
3. cd /foo; ./run.sh
4. logs are in /foo/database/gravity
5. clone galaxy into /bar
6. cd /bar; ./run.sh
7. logs are still in foo/database/gravity; gravity dir not created in bar/database

Expected behavior
Unless I am mistaken, the correct value should be exported in .venv/bin/activate (the code is there).

[nsoranzo]

@ic4f Cannot reproduce by following your instructions, are you sure you don't have manually set GRAVITY_STATE_DIR in your terminal? Since #13685 Galaxy respects that setting if it's exported in the environment.

[jdavcs]

That's it! However, this happens if you manually activate the venv. Deactivating it does not unset it, obviously - so it persists. That's one downside of hacking the activate script in the venv, I'm afraid.

[nsoranzo]

Indeed! I'm not a fan of that hack as well, not sure which could be a better option though.