refactor: opt memory dispose as static member cause

lerna.json

@@ -1,6 +1,6 @@
 {
   "npmClient": "npm",
-  "version": "0.2.5",
+  "version": "0.2.6",
   "bootstrap": {
     "hoist": true
   },

packages/controls/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@oasis-engine/controls",
-  "version": "0.2.5",
+  "version": "0.2.6",
   "license": "MIT",
   "scripts": {
     "b:types": "tsc",
@@ -15,6 +15,6 @@
     "types/**/*"
   ],
   "dependencies": {
-    "oasis-engine": "0.2.5"
+    "oasis-engine": "0.2.6"
   }
 }

packages/core/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@oasis-engine/core",
-  "version": "0.2.5",
+  "version": "0.2.6",
   "license": "MIT",
   "main": "dist/main.js",
   "module": "dist/module.js",
@@ -13,9 +13,9 @@
     "types/**/*"
   ],
   "dependencies": {
-    "@oasis-engine/math": "0.2.5"
+    "@oasis-engine/math": "0.2.6"
   },
   "devDependencies": {
-    "@oasis-engine/design": "0.2.5"
+    "@oasis-engine/design": "0.2.6"
   }
 }

packages/core/src/Camera.ts

@@ -455,7 +455,8 @@ export class Camera extends Component {
    */
   render(cubeFace?: TextureCubeFace): void {
     // compute cull frustm.
-    const context = RenderContext._getRenderContext(this);
+    const context = this.engine._renderContext;
+    context._setContext(this);
     if (this.enableFrustumCulling && (this._frustumViewChangeFlag.flag || this._isFrustumProjectDirty)) {
       this._frustum.calculateFromMatrix(context._viewProjectMatrix);
       this._frustumViewChangeFlag.flag = false;

packages/core/src/Engine.ts

@@ -6,6 +6,8 @@ import { EngineFeature } from "./EngineFeature";
 import { Entity } from "./Entity";
 import { FeatureManager } from "./FeatureManager";
 import { HardwareRenderer } from "./HardwareRenderer";
+import { ClassPool } from "./RenderPipeline/ClassPool";
+import { RenderContext } from "./RenderPipeline/RenderContext";
 import { RenderElement } from "./RenderPipeline/RenderElement";
 import { Scene } from "./Scene";
 import { SceneManager } from "./SceneManager";
@@ -25,6 +27,8 @@ export class Engine extends EventDispatcher {
   _componentsManager: ComponentsManager = new ComponentsManager();
   _hardwareRenderer: HardwareRenderer;
   _lastRenderState: RenderState = new RenderState();
+  _renderElementPool: ClassPool<RenderElement> = new ClassPool(RenderElement);
+  _renderContext: RenderContext = new RenderContext();
 
   /* @internal */
   _renderCount: number = 0;
@@ -183,7 +187,7 @@ export class Engine extends EventDispatcher {
     const deltaTime = time.deltaTime;
 
     time.tick();
-    RenderElement._restPool();
+    this._renderElementPool.restPool();
 
     engineFeatureManager.callFeatureMethod(this, "preTick", [this, this._sceneManager._activeScene]);
 

packages/core/src/RenderPipeline/ClassPool.ts

@@ -0,0 +1,34 @@
+/**
+ * Class pool utils.
+ */
+export class ClassPool<T> {
+  private _elementPoolIndex: number = 0;
+  private _elementPool: T[] = [];
+  private _type: new () => T;
+
+  constructor(type: new () => T) {
+    this._type = type;
+  }
+
+  /**
+   * Get element from pool.
+   */
+  getFromPool(): T {
+    const { _elementPoolIndex: index, _elementPool: pool } = this;
+    this._elementPoolIndex++;
+    if (pool.length === index) {
+      const element = new this._type();
+      pool.push(element);
+      return element;
+    } else {
+      return pool[index];
+    }
+  }
+
+  /**
+   * Reset pool.
+   */
+  restPool(): void {
+    this._elementPoolIndex = 0;
+  }
+}

packages/core/src/RenderPipeline/RenderContext.ts

@@ -5,20 +5,16 @@ import { Camera } from "../Camera";
  * Rendering context.
  */
 export class RenderContext {
-  private static _renderContext: RenderContext = new RenderContext();
+  /** @internal */
+  _camera: Camera;
+  /** @internal */
+  _viewProjectMatrix: Matrix = new Matrix();
 
   /**
    * @internal
    */
-  static _getRenderContext(camera: Camera): RenderContext {
-    const context = RenderContext._renderContext;
-    context._camera = camera;
-    Matrix.multiply(camera.projectionMatrix, camera.viewMatrix, context._viewProjectMatrix);
-    return context;
+  _setContext(camera: Camera): void {
+    this._camera = camera;
+    Matrix.multiply(camera.projectionMatrix, camera.viewMatrix, this._viewProjectMatrix);
   }
-
-  /** @internal */
-  _camera: Camera;
-  /** @internal */
-  _viewProjectMatrix: Matrix = new Matrix();
 }

packages/core/src/RenderPipeline/RenderElement.ts

@@ -1,4 +1,4 @@
-import { Primitive } from "../graphic";
+import { Primitive } from "../graphic/Primitive";
 import { SubPrimitive } from "../graphic/SubPrimitive";
 import { Material } from "../material/Material";
 import { Renderer } from "../Renderer";
@@ -7,32 +7,6 @@ import { Renderer } from "../Renderer";
  * Render element.
  */
 export class RenderElement {
-  private static _elementPoolIndex: number = 0;
-  private static _elementPool: RenderElement[] = [];
-
-  /**
-   * Get render element from pool.
-   * @remark The return value is only valid for the current frame, and the next frame will be automatically recycled for reuse.
-   */
-  static getFromPool(): RenderElement {
-    const { _elementPoolIndex: index, _elementPool: pool } = RenderElement;
-    RenderElement._elementPoolIndex++;
-    if (pool.length === index) {
-      const element = new RenderElement();
-      pool.push(element);
-      return element;
-    } else {
-      return pool[index];
-    }
-  }
-
-  /**
-   * @internal
-   */
-  static _restPool() {
-    RenderElement._elementPoolIndex = 0;
-  }
-
   /** Render component. */
   component: Renderer;
   /** Primitive. */

packages/core/src/geometry/GeometryRenderer.ts

@@ -51,9 +51,10 @@ export class GeometryRenderer extends Renderer {
       const subGeometries = geometry.subGeometries;
       const renderPipeline = camera._renderPipeline;
       const material = this._material;
+      const renderElementPool = this._engine._renderElementPool;
       for (let i = 0, n = subGeometries.length; i < n; i++) {
         if (material) {
-          const element = RenderElement.getFromPool();
+          const element = renderElementPool.getFromPool();
           element.setValue(this, geometry._primitive, subGeometries[i], material); // CM: need to support multi material
           renderPipeline.pushPrimitive(element);
         }

packages/core/src/mesh/MeshRenderer.ts

@@ -108,13 +108,14 @@ export class MeshRenderer extends Renderer {
 
     const renderPipeline = camera._renderPipeline;
     const { primitives, groups } = mesh;
+    const renderElementPool = this._engine._renderElementPool;
 
     //-- render every primitive
     for (let i = 0, len = primitives.length; i < len; i++) {
       const primitive = primitives[i];
       const material = this._instanceMaterials[i] || this._sharedMaterials[i];
       if (material) {
-        const element = RenderElement.getFromPool();
+        const element = renderElementPool.getFromPool();
         element.setValue(this, primitive, groups[i], material);
         renderPipeline.pushPrimitive(element);
       } else {

packages/design/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@oasis-engine/design",
-  "version": "0.2.5",
+  "version": "0.2.6",
   "license": "MIT",
   "main": "dist/main.js",
   "module": "dist/module.js",

packages/draco/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@oasis-engine/draco",
-  "version": "0.2.5",
+  "version": "0.2.6",
   "license": "MIT",
   "scripts": {
     "b:types": "tsc"
@@ -13,6 +13,6 @@
     "types/**/*"
   ],
   "dependencies": {
-    "@oasis-engine/core": "0.2.5"
+    "@oasis-engine/core": "0.2.6"
   }
 }

packages/framebuffer-picker/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@oasis-engine/framebuffer-picker",
-  "version": "0.2.5",
+  "version": "0.2.6",
   "license": "MIT",
   "main": "dist/main.js",
   "module": "dist/module.js",
@@ -14,6 +14,6 @@
     "types/**/*"
   ],
   "dependencies": {
-    "oasis-engine": "0.2.5"
+    "oasis-engine": "0.2.6"
   }
 }

packages/loader/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@oasis-engine/loader",
-  "version": "0.2.5",
+  "version": "0.2.6",
   "license": "MIT",
   "types": "types/index.d.ts",
   "scripts": {
@@ -13,9 +13,9 @@
     "types/**/*"
   ],
   "dependencies": {
-    "@oasis-engine/core": "0.2.5",
-    "@oasis-engine/draco": "0.2.5",
-    "@oasis-engine/math": "0.2.5",
-    "@oasis-engine/rhi-webgl": "0.2.5"
+    "@oasis-engine/core": "0.2.6",
+    "@oasis-engine/draco": "0.2.6",
+    "@oasis-engine/math": "0.2.6",
+    "@oasis-engine/rhi-webgl": "0.2.6"
   }
 }

packages/math/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@oasis-engine/math",
-  "version": "0.2.5",
+  "version": "0.2.6",
   "license": "MIT",
   "main": "dist/main.js",
   "module": "dist/module.js",
@@ -13,6 +13,6 @@
     "types/**/*"
   ],
   "devDependencies": {
-    "@oasis-engine/design": "0.2.5"
+    "@oasis-engine/design": "0.2.6"
   }
 }

packages/oasis-engine/package.json

@@ -1,6 +1,6 @@
 {
   "name": "oasis-engine",
-  "version": "0.2.5",
+  "version": "0.2.6",
   "license": "MIT",
   "scripts": {
     "b:types": "tsc"
@@ -14,9 +14,9 @@
     "types/**/*"
   ],
   "dependencies": {
-    "@oasis-engine/core": "0.2.5",
-    "@oasis-engine/loader": "0.2.5",
-    "@oasis-engine/math": "0.2.5",
-    "@oasis-engine/rhi-webgl": "0.2.5"
+    "@oasis-engine/core": "0.2.6",
+    "@oasis-engine/loader": "0.2.6",
+    "@oasis-engine/math": "0.2.6",
+    "@oasis-engine/rhi-webgl": "0.2.6"
   }
 }

packages/rhi-webgl/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@oasis-engine/rhi-webgl",
-  "version": "0.2.5",
+  "version": "0.2.6",
   "license": "MIT",
   "main": "dist/main.js",
   "module": "dist/module.js",
@@ -13,10 +13,10 @@
     "types/**/*"
   ],
   "dependencies": {
-    "@oasis-engine/core": "0.2.5",
-    "@oasis-engine/math": "0.2.5"
+    "@oasis-engine/core": "0.2.6",
+    "@oasis-engine/math": "0.2.6"
   },
   "devDependencies": {
-    "@oasis-engine/design": "0.2.5"
+    "@oasis-engine/design": "0.2.6"
   }
 }

packages/stats/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@oasis-engine/stats",
-  "version": "0.2.5",
+  "version": "0.2.6",
   "license": "MIT",
   "scripts": {
     "b:types": "tsc"
@@ -14,6 +14,6 @@
     "types/**/*"
   ],
   "dependencies": {
-    "oasis-engine": "0.2.5"
+    "oasis-engine": "0.2.6"
   }
 }

packages/tween/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@oasis-engine/tween",
-  "version": "0.2.5",
+  "version": "0.2.6",
   "license": "MIT",
   "main": "dist/main.js",
   "module": "dist/module.js",
@@ -14,6 +14,6 @@
   },
   "types": "types/index.d.ts",
   "dependencies": {
-    "oasis-engine": "0.2.5"
+    "oasis-engine": "0.2.6"
   }
 }