Skip to content

Comments

refactor: opt memory dispose as static member cause#130

Merged
GuoLei1990 merged 3 commits intogalacean:mainfrom
GuoLei1990:main
Mar 29, 2021
Merged

refactor: opt memory dispose as static member cause#130
GuoLei1990 merged 3 commits intogalacean:mainfrom
GuoLei1990:main

Conversation

@GuoLei1990
Copy link
Member

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

static member cause some reference can't clear.
we use instance member instead of static membe.

@GuoLei1990 GuoLei1990 added the bug Something isn't working label Mar 29, 2021
@GuoLei1990 GuoLei1990 requested a review from zhuxudong March 29, 2021 10:11
Copy link
Member

@zhuxudong zhuxudong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@GuoLei1990 GuoLei1990 merged commit f53103d into galacean:main Mar 29, 2021
@zhuxudong
Copy link
Member

#131

luzhuang pushed a commit to luzhuang/engine that referenced this pull request Sep 6, 2022
* refactor: opt memory dispose as static member cause
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants