Skip to content

Remove lodash dependency #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 1.x
Choose a base branch
from
Open

Remove lodash dependency #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50264fc
Remove lodash dependency
rafeca Aug 11, 2017
77696d3
Use a standard JS object instead of a Set
rafeca Aug 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@
"webpack": "1.4.8"
},
"dependencies": {
"lodash": "^4.6.1",
"react-deep-force-update": "^1.0.0"
}
}
5 changes: 2 additions & 3 deletions src/createClassProxy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import find from 'lodash/find';
import createPrototypeProxy from './createPrototypeProxy';
import bindAutoBindMethods from './bindAutoBindMethods';
import deleteUnknownAutoBindMethods from './deleteUnknownAutoBindMethods';
Expand Down Expand Up @@ -32,14 +31,14 @@ function isEqualDescriptor(a, b) {
// https://github.com/gaearon/react-proxy/issues/50#issuecomment-192928066
let allProxies = [];
function findProxy(Component) {
const pair = find(allProxies, ([key]) => key === Component);
const pair = allProxies.find(([key]) => key === Component);
return pair ? pair[1] : null;
}
function addProxy(Component, proxy) {
allProxies.push([Component, proxy]);
}

export default function proxyClass(InitialComponent) {
export function proxyClass(InitialComponent) {
// Prevent double wrapping.
// Given a proxy class, return the existing proxy managing it.
var existingProxy = findProxy(InitialComponent);
Expand Down
20 changes: 15 additions & 5 deletions src/createPrototypeProxy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
import assign from 'lodash/assign';
import difference from 'lodash/difference';

export default function createPrototypeProxy() {
let proxy = {};
let current = null;
Expand Down Expand Up @@ -32,7 +29,7 @@ export default function createPrototypeProxy() {
};

// Copy properties of the original function, if any
assign(proxiedMethod, current[name]);
Object.assign(proxiedMethod, current[name]);
proxiedMethod.toString = proxyToString(name);

return proxiedMethod;
Expand Down Expand Up @@ -134,7 +131,20 @@ export default function createPrototypeProxy() {
// Find changed property names
const currentNames = Object.getOwnPropertyNames(current);
const previousName = Object.getOwnPropertyNames(proxy);
const removedNames = difference(previousName, currentNames);

// Map the property names as keys in an object to get constant time access
// when calculating the removed properties.
const currentNamesObject = currentNames.reduce(
(acc, property) => {
acc[property] = true;
return acc;
},
Object.create(null),
);

const removedNames = previousName.filter(
property => !currentNames[property],
);

// Remove properties and methods that are no longer there
removedNames.forEach(name => {
Expand Down