Remove lodash dependency #79
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since all the lodash functionality used in this module can be currently implemented easily using ES6, there is no need to include it. This allows a bundle size reduction when using HMR of ~77KB
Since the property names are strings, we can safely use standard objects to ensure that we get constant access time (by using a `Set` we have the risk that it's polyfilled and that the polyfill does not optimize the string use case).
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since all the
lodashfunctionality used in this module can be currentlyimplemented easily using ES6, there is no need to include it.
When using
metro-bundlerwith Hot Module Reloading in React Native, this change reduces the bundle size by ~77KB and makesmetro-bundlerbuild around ~150 less modules.