Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Docker Compose Run Flags #443

Merged
merged 8 commits into from
Jun 17, 2023
Merged

Additional Docker Compose Run Flags #443

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
673f3df
additions
ethanleifer May 24, 2023
b2bb654
Merge branch 'master' into run_--build_flag
gabrieldemarmiesse May 25, 2023
6b4f340
test compose remove orphans
ethanleifer May 25, 2023
ce8c91a
run build tests
ethanleifer May 25, 2023
612ef6f
fix lint
ethanleifer May 25, 2023
2079a33
Merge branch 'master' into run_--build_flag
ethanleifer May 25, 2023
86ca232
strip remove orphans
ethanleifer May 27, 2023
b5f0570
format
ethanleifer May 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
additions
  • Loading branch information
@ethanleifer
ethanleifer committed May 24, 2023
commit 673f3df89632fdf620f5f0a4f61030be687dc4f5
4 changes: 4 additions & 0 deletions python_on_whales/components/compose/cli_wrapper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,6 +496,7 @@ def run(
self,
service: str,
command: List[str] = [],
build: bool = False,
detach: bool = False,
# entrypoint: Optional[List[str]] = None,
# envs: Dict[str, str] = {},
Expand All @@ -507,6 +508,7 @@ def run(
publish: List[
python_on_whales.components.container.cli_wrapper.ValidPortMapping
] = [],
remove_orphans: bool = False,
remove: bool = False,
service_ports: bool = False,
use_aliases: bool = False,
Expand Down Expand Up @@ -560,6 +562,7 @@ def run(
"Try setting tty=False in docker.compose.run(...)."
)
full_cmd = self.docker_compose_cmd + ["run"]
full_cmd.add_flag("--build", build)
full_cmd.add_flag("--detach", detach)
full_cmd.add_simple_arg("--name", name)
full_cmd.add_flag("--no-TTY", not tty)
Expand All @@ -573,6 +576,7 @@ def run(
f"{port_mapping[0]}:{port_mapping[1]}/{port_mapping[2]}",
]

full_cmd.add_flag("--remove-orphans", remove_orphans)
full_cmd.add_flag("--rm", remove)
full_cmd.add_flag("--service-ports", service_ports)
full_cmd.add_flag("--use-aliases", use_aliases)
Expand Down