Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Docker Compose Run Flags #443

Merged

Conversation

ethanleifer
Copy link
Contributor

@ethanleifer ethanleifer commented May 24, 2023

First time pring here.

Fixing Issue #442

I added two flags to compose.run

build: bool = False

I added them using the full_cmd.add_flag function.

I matched the default values and ordering of the docker compose docs

Copy link
Owner

@gabrieldemarmiesse gabrieldemarmiesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the pull request. Could you write some simple unit tests for those two flags? Thanks a lot. You can write them here: https://github.com/gabrieldemarmiesse/python-on-whales/blob/master/tests/python_on_whales/components/test_compose.py

You can read the other tests for inspiration.

@ethanleifer
Copy link
Contributor Author

ethanleifer commented May 27, 2023

I removed the remove_orphans since I was having issues getting the expected output locally

Should be good to merge now @gabrieldemarmiesse

@gabrieldemarmiesse
Copy link
Owner

Thank you! I'll take a look :)

@gabrieldemarmiesse gabrieldemarmiesse enabled auto-merge (squash) June 17, 2023 12:33
@gabrieldemarmiesse gabrieldemarmiesse merged commit 730c48a into gabrieldemarmiesse:master Jun 17, 2023
@gabrieldemarmiesse
Copy link
Owner

Thank you for the pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants