-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional Docker Compose Run Flags #443
Additional Docker Compose Run Flags #443
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the pull request. Could you write some simple unit tests for those two flags? Thanks a lot. You can write them here: https://github.com/gabrieldemarmiesse/python-on-whales/blob/master/tests/python_on_whales/components/test_compose.py
You can read the other tests for inspiration.
I removed the remove_orphans since I was having issues getting the expected output locally Should be good to merge now @gabrieldemarmiesse |
Thank you! I'll take a look :) |
Thank you for the pull request! |
First time pring here.
Fixing Issue #442
I added two flags to
compose.run
I added them using the
full_cmd.add_flag
function.I matched the default values and ordering of the docker compose docs