This repository was archived by the owner on Mar 31, 2023. It is now read-only.
[DPM] Add rollback mechanism for failure of sending TopicInfo #726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to dpm-pulsarv2
…o dpm-pulsarv2-async
VanderChen
changed the title
cj-chung
reviewed
Jan 26, 2022
Comment on lines
+88
to
+89
| vpcTopicInfoICache.put(vpcId, vpcTopicInfo); | ||
| tx.commit(); |
Contributor
There was a problem hiding this comment.
@VanderChen So we allow to put a null into vpcTopicInfoICache for certain vpcId?
cj-chung
approved these changes
Jan 26, 2022
Contributor
cj-chung
left a comment
cj-chung
left a comment
There was a problem hiding this comment.
LGTM overall except one minor comment, but I think we can merge it into master first.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we add a rollback mechanism for failure of sending TopicInfo. When sending topic info using gRPC fails, delete the corresponding TopicInfo in the TopicInfoCache.