Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IP address to scan results #602

Merged
merged 1 commit into from
Feb 19, 2018

Conversation

knqyf263
Copy link
Contributor

@knqyf263 knqyf263 commented Feb 19, 2018

What did you implement:

Add IP addresses of the scanned server to scan results.

How did you implement it:

Execute ip addr or ifconfig (depends on OS).
Skip loopback address or link-local address, etc. (https://golang.org/pkg/net/#IP.IsGlobalUnicast)

How can we verify it:

Check JSON results after scan.
It will contain IPv4Addrs and IPv6Addrs.

Todos:

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO (Only add columns)

@knqyf263 knqyf263 requested a review from kotakanbe February 19, 2018 02:53
@knqyf263 knqyf263 self-assigned this Feb 19, 2018
@kotakanbe kotakanbe merged commit 7a5793c into future-architect:master Feb 19, 2018
@kotakanbe
Copy link
Member

Pretty!

@knqyf263 knqyf263 deleted the add_ipaddr branch February 19, 2018 05:38
kotakanbe added a commit that referenced this pull request Mar 2, 2018
* master:
  Support a reporting via Syslog (#604)
  fix: add some logging for goval-dictionary (#603)
  Add IP address to scan results (#602)
  Support AWS S3 Server-Side Encryption (#597)
  fix: Kindness error message in reporting (#601)
  Update deps (#592)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants