Support AWS S3 Server-Side Encryption #597
Merged
+21
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Support AWS S3 Server-Side Encryption
https://docs.aws.amazon.com/AmazonS3/latest/dev/UsingServerSideEncryption.html
How did you implement it:
Adding a new
-aws-s3-server-side-encryption
option which can be used to set the SSE method.How can we verify it:
Publish reports to S3 with
-aws-s3-server-side-encryption=AES256
.They should have the
Encryption
property set toAES256
.Todos:
You don't have to satisfy all of the following.
make fmt
make test
Is this ready for review?: YES
Is it a breaking change?: NO