Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support AWS S3 Server-Side Encryption #597

Merged
merged 2 commits into from
Feb 12, 2018
Merged

Conversation

MiLk
Copy link
Contributor

@MiLk MiLk commented Feb 2, 2018

What did you implement:

Support AWS S3 Server-Side Encryption
https://docs.aws.amazon.com/AmazonS3/latest/dev/UsingServerSideEncryption.html

How did you implement it:

Adding a new -aws-s3-server-side-encryption option which can be used to set the SSE method.

How can we verify it:

Publish reports to S3 with -aws-s3-server-side-encryption=AES256.
They should have the Encryption property set to AES256.

Todos:

You don't have to satisfy all of the following.

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@kotakanbe
Copy link
Member

@MiLk
Copy link
Contributor Author

MiLk commented Feb 12, 2018

Done in vulsdoc/vuls#12

@kotakanbe kotakanbe merged commit 562ff78 into future-architect:master Feb 12, 2018
@kotakanbe
Copy link
Member

@MiLk Many thanks :)

@MiLk MiLk deleted the s3-sse branch February 12, 2018 02:29
kotakanbe added a commit that referenced this pull request Mar 2, 2018
* master:
  Support a reporting via Syslog (#604)
  fix: add some logging for goval-dictionary (#603)
  Add IP address to scan results (#602)
  Support AWS S3 Server-Side Encryption (#597)
  fix: Kindness error message in reporting (#601)
  Update deps (#592)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants