Insert sudo only at the beginning of command in deep scan #495
#539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kotakanbe
added a commit
that referenced
this pull request
Nov 15, 2017
* master: Fix yum changelog option (#543) Update README.md (#542) Fix false positive: ignore oval info when kernel major version is different. (#541) Fix: Misdetection of OvalMatch for CentOS and Scientific in oval/util.go (#536) Fix: "Reboot Required" detection process in scan/redhat.go (#534) Remove README.fr.md because unable to maintenance.. README Typo Update (#538) Insert `sudo` only at the beginning of command in deep scan #495 (#539) Fix config.toml validation (#537) Add pseudo server type for non-ssh scanning (only cpe scan) #512 (#531) README Update (#530) Update README send slack msg by api (#525) fix typo Privious -> Previous (#523) Fix package query fails on debian based container (#519) (#522) fix typo from "enviroment" to "environment" (#518) Fix typo in config/jsonloader.go (#517) Modified Spell Miss of "README.md". (#516) Fix .goreleaser.yml Fix a bug of making channels when fill oval information via HTTP (#514)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Solve the problem that RedHat's deep scan stops halfway.
#495 (comment)
How did you implement it:
In the current implementation, the command to be PIPE only existed in
yum changelogin redhat.goHow can we verify it:
scan RedHat with --deep
Todos:
You don't have to satisfy all of the following.
make fmtmake testIs this ready for review?: NO
Is it a breaking change?: NO