Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Slack's Thread in notification #525

Merged
merged 1 commit into from
Oct 26, 2017
Merged

Support Slack's Thread in notification #525

merged 1 commit into from
Oct 26, 2017

Conversation

sadayuki-matsuno
Copy link
Collaborator

What did you implement:

Fix to send slack notification using API.
By using thread in API, slack message does not become chaos.

How did you implement it:

add function to send msg by api

How can we verify it:

  • get slack legacy api token

https://api.slack.com/custom-integrations/legacy-tokens

  • add slack api token into config.toml
[slack]
#hookURL      = "https://hooks.slack.com/services/abc123/defghijklmnopqrstuvwxyz"
legacyToken =       "xoxp-11111111111-legacytoken-1111111111"
channel      = "#channel"
iconEmoji    = ":ghost:"
authUser     = "vuls"
notifyUsers  = ["@matsuno"]
  • run vuls report
$ vuls report -to-slack -cvss-over=7
  • result

2017-10-21 6 27 33

Todos:

You don't have to satisfy all of the following.

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: YES

@kotakanbe kotakanbe merged commit eb2acaf into future-architect:master Oct 26, 2017
@kotakanbe
Copy link
Member

Great!
Many Thanks :)

@kotakanbe kotakanbe changed the title send slack msg by api Support Slack's Thread in notification Oct 26, 2017
@kotakanbe kotakanbe mentioned this pull request Oct 27, 2017
Closed
kotakanbe added a commit that referenced this pull request Nov 15, 2017
@kotakanbe
Merge branch 'master' into v0.5.0
642b4c3 
* master:
  Fix yum changelog option (#543)
  Update README.md (#542)
  Fix false positive: ignore oval info when kernel major version is different. (#541)
  Fix: Misdetection of OvalMatch for CentOS and Scientific in oval/util.go (#536)
  Fix: "Reboot Required" detection process in scan/redhat.go (#534)
  Remove README.fr.md because unable to maintenance..
  README Typo Update (#538)
  Insert `sudo` only at the beginning of command in deep scan #495 (#539)
  Fix config.toml validation (#537)
  Add pseudo server type for non-ssh scanning (only cpe scan) #512 (#531)
  README Update (#530)
  Update README
  send slack msg by api (#525)
  fix typo Privious -> Previous (#523)
  Fix package query fails on debian based container (#519) (#522)
  fix typo from "enviroment" to "environment" (#518)
  Fix typo in config/jsonloader.go (#517)
  Modified Spell Miss of "README.md". (#516)
  Fix .goreleaser.yml
  Fix a bug of making channels when fill oval information via HTTP (#514)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sadayuki-matsuno @kotakanbe