Skip to content

Eddystone beacons wrongly identified as iBeacons #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 27, 2018
Merged

Eddystone beacons wrongly identified as iBeacons #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions lib/parser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,6 @@ BeaconParser.prototype.parse = function(peripheral) {
BeaconParser.prototype._detectBeaconType = function(peripheral) {
let ad = peripheral.advertisement;
let manu = ad.manufacturerData;
// iBeacon
if(manu && manu.length >= 4 && manu.readUInt32BE(0) === 0x4c000215) {
return 'iBeacon';
}
// Eddiystone
let eddystone_service = ad.serviceData.find((el) => {
return el.uuid === this._EDDYSTONE_SERVICE_UUID;
Expand All @@ -91,6 +87,10 @@ BeaconParser.prototype._detectBeaconType = function(peripheral) {
return 'eddystoneEid';
}
}
// iBeacon
if(manu && manu.length >= 4 && manu.readUInt32BE(0) === 0x4c000215) {
return 'iBeacon';
}
// Estimote Telemetry
let telemetry_service = ad.serviceData.find((el) => {
return el.uuid === this._ESTIMOTE_TELEMETRY_SERVICE_UUID;
Expand All @@ -106,4 +106,4 @@ BeaconParser.prototype._detectBeaconType = function(peripheral) {
return '';
};

module.exports = new BeaconParser();
module.exports = new BeaconParser();