Eddystone beacons wrongly identified as iBeacons #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I encountered a problem, where after a short time, only iBeacons got detected. I digged into the code and saw, that while the rule for detecting iBeacons was valid, the rule for detecting eddystone beacons was also valid. This means, that it could have been both, ibeacon and eddystone. But as far as the eddystone identification uses a UUID, which should be unique, i think, beacons having this uuid should not be misidentified as ibeacons. I simply changed the order, that whenever the uuid is valid, it is a eddystone beacon. Otherwise it can also be an iBeacon.
|
Thank you so much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
while using this library on a raspberry pi with 2 sample beacons, I encountered a problem, where after a short while only iBeacons got detected although eddystone beacons were present.
After a short inspection of the code i noticed that in the parser.js the check for iBeacons comes before the check for eddystone beacons. I also noticed that the check for those two kinds of beacons is different. While an eddystone beacon is detected by a unique ServiceUUID, the detection of iBeacons relies on manufacturer data.
After some checks, I realised, that some of the beacons matching the criteria for eddystone (ServiceUUID == "feaa") were classified as iBeacons, because those criteria was also matched.
By rearranging the order of matching (first eddystone then iBeacon), I think I solved the problem. Because my raspberry pi now detects iBeacons and eddystone beacons in roughly the same proprtion.