Skip to content
This repository was archived by the owner on Jan 31, 2023. It is now read-only.

ESM source, use yarn and esbuild #572

Merged
merged 3 commits into from
Jan 13, 2023
Merged

ESM source, use yarn and esbuild #572

merged 3 commits into from
Jan 13, 2023

Conversation

stellarhoof
Copy link
Contributor

@stellarhoof stellarhoof commented Jan 13, 2023 •
edited
Loading

Now you can actually do const cr = await import('contexture-react') from a node repl!

  • Convert source to ESM
  • Fix some invalid imports (how did this even work?)
  • Change futil imports from import * as F from futil to import F from futil. The former doesn't work with ESM
  • Do not import date picker css files. They don't work with ESM and user should at least have the choice to style the date inputs however they want.

@stellarhoof stellarhoof self-assigned this Jan 13, 2023
@stellarhoof stellarhoof marked this pull request as draft January 13, 2023 16:20
@stellarhoof stellarhoof force-pushed the feature/yarn-esbuild branch 2 times, most recently from 6e849f1 to b873b8a Compare January 13, 2023 16:31
@futil-js futil-js deleted a comment from decrapifier Jan 13, 2023
@futil-js futil-js deleted a comment from decrapifier Jan 13, 2023
@futil-js futil-js deleted a comment from decrapifier Jan 13, 2023
@futil-js futil-js deleted a comment from decrapifier Jan 13, 2023
@stellarhoof stellarhoof marked this pull request as ready for review January 13, 2023 16:46
@stellarhoof stellarhoof changed the title Use yarn and esbuild ESM source, use yarn and esbuild Jan 13, 2023
@decrapifier
Copy link
Contributor

Warnings
⚠️ ❗ This PR is BIG (+18061 -54046) Please keep it below 500 net changes
Messages
📖 You reduced the total lines of code! Awesome! 👍

Generated by 🚫 dangerJS against d178cc6

@futil-js futil-js deleted a comment from decrapifier Jan 13, 2023
@stellarhoof stellarhoof merged commit cd49027 into master Jan 13, 2023
@stellarhoof stellarhoof deleted the feature/yarn-esbuild branch January 13, 2023 22:45
@stellarhoof stellarhoof mentioned this pull request Jan 13, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ccalbaugh ccalbaugh ccalbaugh approved these changes

@rudolph9 rudolph9 Awaiting requested review from rudolph9

@re1ro re1ro Awaiting requested review from re1ro

@daedalus28 daedalus28 Awaiting requested review from daedalus28

@dshishkov dshishkov Awaiting requested review from dshishkov

Assignees

@stellarhoof stellarhoof

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stellarhoof @decrapifier @ccalbaugh