Skip to content
This repository was archived by the owner on Jan 31, 2023. It is now read-only.

Commit 1eb6929

Browse files
committed
Merge branch 'master' into feature/yarn-esbuild
2 parents 211286e + 0a67475 commit 1eb6929

File tree

4 files changed

+42
-31
lines changed

4 files changed

+42
-31
lines changed

CHANGELOG.mdx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,11 @@
1-
### 2.54.8
1+
### 2.54.9
22
* Use yarn
33
* Use eslint to build source
44
* Convert package to ESM
55

6+
### 2.54.8
7+
* FilterList - Add `resultsPath` similar to how it is used in TagsQuerySearchBar to indicate if we need to trigger tree update
8+
69
### 2.54.7
710
* Fix MemoryTable rendering
811

package.json

Lines changed: 17 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "contexture-react",
3-
"version": "2.54.8",
3+
"version": "2.54.9",
44
"description": "React components for building contexture interfaces",
55
"type": "module",
66
"main": "dist/esm/index.js",
@@ -9,7 +9,7 @@
99
],
1010
"scripts": {
1111
"prepack": "node scripts/build.js",
12-
"fmt": "prettier --ignore-path .gitignore --write .",
12+
"fmt": "prettier --ignore-path .gitignore --write src",
1313
"lint": "eslint --ignore-path .gitignore .",
1414
"lint:ci": "yarn lint -o lint-results.json -f json",
1515
"duti:fix": "yarn lint --fix && yarn fmt",
@@ -46,20 +46,6 @@
4646
"storybook-deployer": {
4747
"commitMessage": "Deploy Storybook [ci skip]"
4848
},
49-
"dependencies": {
50-
"futil": "^1.71.8",
51-
"lodash": "^4.17.15",
52-
"moment": "^2.24.0",
53-
"pluralize": "^8.0.0",
54-
"prop-types": "^15.7.2",
55-
"react-date-picker": "^7.2.0",
56-
"react-dnd": "^2.5.4",
57-
"react-dnd-html5-backend": "^2.5.4",
58-
"react-measure": "^2.3.0",
59-
"react-outside-click-handler": "^1.2.3",
60-
"react-recompose": "^0.31.2",
61-
"reactjs-popup": "^2.0.4"
62-
},
6349
"devDependencies": {
6450
"@date-io/moment": "^1.3.9",
6551
"@material-ui/core": "^4.3.3",
@@ -94,5 +80,20 @@
9480
"read-pkg": "^5.2.0",
9581
"write-pkg": "^4.0.0"
9682
},
83+
"dependencies": {
84+
"futil": "^1.71.8",
85+
"lodash": "^4.17.15",
86+
"moment": "^2.24.0",
87+
"pluralize": "^8.0.0",
88+
"prop-types": "^15.7.2",
89+
"react-date-picker": "^7.2.0",
90+
"react-dnd": "^2.5.4",
91+
"react-dnd-html5-backend": "^2.5.4",
92+
"react-measure": "^2.3.0",
93+
"react-outside-click-handler": "^1.2.3",
94+
"react-recompose": "^0.31.2",
95+
"reactjs-popup": "^2.0.4"
96+
},
97+
"readme": "README.mdx",
9798
"packageManager": "yarn@3.3.1"
9899
}

src/FilterList.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -162,15 +162,16 @@ let FilterList = _.flow(
162162
tree,
163163
node,
164164
fields,
165+
resultsPath,
165166
mapNodeToProps = _.noop,
166167
mapNodeToLabel = _.noop,
167168
className,
168169
style,
169170
theme: { UnmappedNodeComponent, Button },
170171
}) => {
171-
// find if any nodes in the tree are marked for update
172-
// i.e. usually nodes are marked for update because they react to "others" reactor
173-
let updateRequired = tree.disableAutoUpdate && node.markedForUpdate
172+
// find results node that this filter node is targeting (['root', 'results'])
173+
let updateRequired =
174+
tree.disableAutoUpdate && tree.getNode(resultsPath)?.markedForUpdate
174175

175176
return (
176177
<div style={style} className={className}>

src/exampleTypes/CheckableTermsStatsTable.js

Lines changed: 17 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -20,17 +20,23 @@ let CheckableTermsStatsTable = ({
2020
selected
2121
)
2222
return (
23-
<TermsStatsTable {...props}>
24-
<Column
25-
label={<Checkbox checked={allChecked} onChange={checkAll} />}
26-
display={(x, y) => (
27-
<Checkbox
28-
{...F.domLens.checkboxValues(_.iteratee(getValue)(y), selected)}
29-
/>
30-
)}
31-
/>
32-
{children}
33-
</TermsStatsTable>
23+
<TermsStatsTable
24+
{...{
25+
...props,
26+
children: [
27+
<Column
28+
key="checkbox"
29+
label={<Checkbox checked={allChecked} onChange={checkAll} />}
30+
display={(x, y) => (
31+
<Checkbox
32+
{...F.domLens.checkboxValues(_.iteratee(getValue)(y), selected)}
33+
/>
34+
)}
35+
/>,
36+
...children,
37+
],
38+
}}
39+
/>
3440
)
3541
}
3642

0 commit comments

Comments
 (0)