-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark Duplicate Bitflag & include secondary & Supplimentary Reads #934
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etection strategies. Set duplicate flag as needed on all reads inside Template which are not the top scoring read set.
My apologies @JoeVieira - this is definitely on my list to look at, I've just been swamped recently. In all honestly it'll probably be another week or so until I have the time to do a thorough review. |
@tfenne thanks for the response - no worries, appreciate the transparency! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #906 & #920
This exposes a few new options
-d
Set duplicate bit flag on all non-representative reads-D
representative read strategy, accepts strategies from htslib.Representative read is chosen by the sum scores ( from the scoring strategy ) across all primary reads, ties are broken with sum of mapping qualities from primary reads.
-S
include secondary reads in output ( also mark duplicates on as needed )-U
include supplementary reads in output ( mark as needed )