Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove VariantContexts from most fgbio tools #836

Open
wants to merge 7 commits into
base: ks_remove_variantcontextsetbuilder
Choose a base branch
from

Conversation

kstromhaug
Copy link
Contributor

@kstromhaug kstromhaug commented Apr 29, 2022

Changes to

VariantMask
UpdateVcfContigNames
JointVariantContextIterator
ByIntervalListVariantContextIterator
AssessPhasing
ErrorRateByReadPosition

To remove VariantContexts and other elements of HTSJDK

and associated tests

MakeMixtureVcf has a modified line so that everything will compile, but still passes all tests which is a little concerning.

@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2022

Codecov Report

Merging #836 (c81cca1) into main (bb36b51) will increase coverage by 0.12%.
The diff coverage is 98.75%.

@@            Coverage Diff             @@
##             main     #836      +/-   ##
==========================================
+ Coverage   95.58%   95.71%   +0.12%     
==========================================
  Files         122      125       +3     
  Lines        7068     7282     +214     
  Branches      511      490      -21     
==========================================
+ Hits         6756     6970     +214     
  Misses        312      312              
Flag Coverage Δ
unittests 95.71% <98.75%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../fulcrumgenomics/vcf/MakeTwoSampleMixtureVcf.scala 97.61% <0.00%> (ø)
.../fulcrumgenomics/bam/ErrorRateByReadPosition.scala 97.00% <100.00%> (ø)
.../scala/com/fulcrumgenomics/vcf/AssessPhasing.scala 97.74% <100.00%> (+0.03%) ⬆️
...ics/vcf/ByIntervalListVariantContextIterator.scala 92.00% <100.00%> (ø)
...crumgenomics/vcf/JointVariantContextIterator.scala 90.00% <100.00%> (+3.33%) ⬆️
...com/fulcrumgenomics/vcf/UpdateVcfContigNames.scala 100.00% <100.00%> (ø)
...in/scala/com/fulcrumgenomics/vcf/VariantMask.scala 100.00% <100.00%> (ø)
.../fulcrumgenomics/umi/ReviewConsensusVariants.scala 95.96% <0.00%> (-1.62%) ⬇️
.../scala/com/fulcrumgenomics/bam/api/SamWriter.scala 100.00% <0.00%> (ø)
...fulcrumgenomics/umi/CallDuplexConsensusReads.scala 100.00% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb36b51...c81cca1. Read the comment docs.

@kstromhaug kstromhaug changed the base branch from main to ks_remove_variantcontextsetbuilder April 29, 2022 20:25
@kstromhaug kstromhaug marked this pull request as ready for review April 29, 2022 20:56
@kstromhaug kstromhaug requested a review from nh13 April 29, 2022 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants