Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic implementation of an adapter for locatable. #569

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 59 additions & 0 deletions src/main/scala/com/fulcrumgenomics/util/LocatableAdapter.scala
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
/*
* The MIT License
*
* Copyright (c) 2020 Fulcrum Genomics LLC
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to deal
* in the Software without restriction, including without limitation the rights
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the Software is
* furnished to do so, subject to the following conditions:
*
* The above copyright notice and this permission notice shall be included in
* all copies or substantial portions of the Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
* THE SOFTWARE.
*/

package com.fulcrumgenomics.util

import com.fulcrumgenomics.FgBioDef._

import htsjdk.samtools.util.{CoordMath, Locatable}

/**
* Trait that can be added to any class that defines chrom/start/end to implement Locatable
*/
trait LocatableAdapter[A <: LocatableAdapter[A]] extends Locatable with Ordered[A] {
def chrom: String
def start: Int
def end: Int
def name: String
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be here? Should it have a default = "" or perhaps have type Option[String] = None? Or should we have a NamedLocatable sub-trait?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it needs a name at all. Things like Variant are locatable, but don't have a name (could default to id). NamedLocatable seems also overkill until we have sub-classes that could benefit from a common NamedLocatable trait. For the latter, what would NamedLocatable help with? Would we have methods somewhere that operate on name? That seems a bit kludgy until we have examples.

def negativeStrand: Boolean
def positiveStrand: Boolean = !negativeStrand

// Implementations of Locatable interface methods
final override def getContig: String = chrom
final override def getStart: Int = start
final override def getEnd: Int = end

final def length: Int = getLengthOnReference

/** Calculates the overlap between two locatables assuming that they do in fact overlap. */
def overlap(other: Locatable): Int = CoordMath.getOverlap(start, end, other.getStart, other.getEnd)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be bullet-proofed to check for overlap first or return 0 if they don't overlap.


/** Provides a basic comparison that orders on chrom (lexicographically) and then start and end position. */
def compare(that: A): Int = {
var result = this.chrom.compareTo(that.chrom)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have a trait LocatableWithSequenceDictionary (I'm bad at naming) that has a def contigIdx method (or val), so that we can have karyotype order versus lexicographical?

if (result == 0) result = this.start - that.start
if (result == 0) result = this.end - that.end
result
}
}