2.3 develop #1
Merged
2.3 develop #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adding tests for adding widget into WYSIWYG content area.
… tinymce3 and tinymce4
… tinymce3 and tinymce4
…ick on variable placeholder 1 times
- adding comment for supporting multiple ors
-fix js failures
…ick on variable placeholder 1 times
…ick on variable placeholder 1 times
- fix js static test failures
- fix js static test failures
- fix js static test failures
- Removing CKEditor and making static build error changes.
… SKU Prepare unique_id value if it doesn't exist
…cription - Make wysiwygInstance a unique property on the instance of wysiwygInstance rather than on its shared prototype
- Adding a name to the ActiveEditor block.
- Changing the MD5 hashing to sha256
Removing the banned word from the url for Tinymce in the help module. We don't use this module and even if we did the url will direct the user to the tinymce website.
- Added a dependency to Cms to UI
- Removing the redundant dependancy on Cms from the UI module.
Changed the htmlentities function to the htmlspecialchars function. It's not necessary to do HTML encoding on all characters as described in #10682. Since the content is used within HTML tags, we still need to encode special HTML chars in order to make sure that chars like "'& etc, will not break the page.
- Removed Magento\Framework\Locale\CurrencyInterface from setService method and changed it to \Zend_Currency_CurrencyInterface which must be provider to this function. - Changed return type to \Zend_Currency_CurrencyInterface, the given instance of the service is returned by the setService function - Removed \Zend_Service from getService method and changed it to \Zend_Currency_CurrencyInterface - Added @deprecated tags to both methods and added @see annotation to the methods. Referenced corresponding interface \Magento\Directory\Model\Currency\Import\ImportInterface
Accepted Public Pull Requests: - #12905: [Backport #12666 into 2.3-develop] Fix incorrect DHL Product codes (by @gwharton) - #12896: Add product ID and SKU to wishlist customer data (by @jameshalsall)
Accepted Public Pull Requests: - #12961: [Backport to 2.3-develop] Fixed double space typo (by @dverkade) - #12872: Fix import from external jpeg images (by @PieterCappelle) Fixed GitHub Issues: - #5306: Images imported via URL have crazy file paths (reported by @hgpit) has been fixed in #12872 by @PieterCappelle in 2.3-develop branch Related commits: 1. 8cdf043 2. 53292d3 - #12455: Import uploader does not check Content-Disposition header (reported by @EliasZ) has been fixed in #12872 by @PieterCappelle in 2.3-develop branch Related commits: 1. 8cdf043 2. 53292d3 - #12533: Unable to import external jpeg images from a CDN with dynamic URLs. (reported by @dromoded) has been fixed in #12872 by @PieterCappelle in 2.3-develop branch Related commits: 1. 8cdf043 2. 53292d3
… and keywords transform to html entities #12955
… Icon Inconsistency #12960
…ly Viewed Products widget options #12947
Accepted Public Pull Requests: - #12955: [Backport to 2.3-develop] Fix #10682: Meta description and keywords transform to html entities (by @dverkade) - #12960: [Backport to 2.3-develop] Fix #11236: Web Setup Wizard Icon Inconsistency (by @dverkade) - #12947: [Port 2.3-develop] Respect "Learn More Link" in Recently Viewed Products widget options (by @JeroenVanLeusden) Fixed GitHub Issues: - #10682: Meta description and keywords transform to html entities for non latin/cyrilic characters in category and product pages (reported by @fouli86) has been fixed in #12955 by @dverkade in 2.3-develop branch Related commits: 1. c49c52a - #11236: Web Setup Wizard Icon Inconsistency (reported by @Franzld) has been fixed in #12960 by @dverkade in 2.3-develop branch Related commits: 1. 8cb5b9c
…nents. Zend_Service #12957
Accepted Public Pull Requests: - #12957: [Backport to 2.3-develop] Fix #9243 - Upgrade ZF components. Zend_Service (by @dverkade) - #12943: Naming collision in Javascript ui registry (backend) (by @VladimirZaets) Fixed GitHub Issues: - #9243: Upgrade ZF components. Zend_Service (reported by @okorshenko) has been fixed in #12957 by @dverkade in 2.3-develop branch Related commits: 1. 68389d6 - #12555: Naming collision in Javascript ui registry (backend) (reported by @EliasZ) has been fixed in #12943 by @VladimirZaets in 2.3-develop branch Related commits: 1. 8580f45
engcom-Foxtrot
pushed a commit
that referenced
this pull request
Oct 31, 2019
Issue #1: Static content deploy waits 3 sec in single-job mode after finish Fixed by moving this sleep() into if ($this->isCanBeParalleled()) { ... } Issue #2: Static content deploy has 5 secs delay between checking if worker job finished processing. It leads up to 5 sec time waste before next job will start. Improved by decreasing time from 5 sec to 0.5 sec with saving log refresh rate (10*0.5 sec) On 4 themes and 7 locales these fixes improve time of static content deploy by 10-15 secs
engcom-Foxtrot
pushed a commit
that referenced
this pull request
Nov 6, 2019
…ription-input-box-fix Fix label being cutoff in Newsletter registration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist