Skip to content

[Backport #12666 into 2.3-develop] Fix incorrect DHL Product codes #12905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2018
Merged

[Backport #12666 into 2.3-develop] Fix incorrect DHL Product codes #12905

merged 1 commit into from
Jan 3, 2018

Conversation

gwharton
Copy link
Contributor

@gwharton gwharton commented Dec 28, 2017

Backport of #12666 into 2.3-develop

Description

There are two DHL product codes in the DHL Shipping module that are incorrect.

Product Code "1" changed from "Customer Services" to "Domestic express 12:00"
Product Code "I" changed from "Break bulk economy" to "Domestic express 9:00"

DHL product codes are now inline with those published in latest DHL products and services guide.

See DHLIS1 - Products and Services

Fixed Issues (if relevant)

N/A

Manual testing scenarios

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Updated Incorrect product codes in DHL module.
@miguelbalparda
Copy link
Contributor

This is going to be merged soon, thanks @gwharton!

@magento-team magento-team merged commit f3409be into magento:2.3-develop Jan 3, 2018
magento-team pushed a commit that referenced this pull request Jan 3, 2018
@gwharton gwharton deleted the 2.3-develop-gw-dhl branch January 13, 2018 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants