Fix idempotency problem with multiline quotation expressions. #2211
Conversation
Extend Quote handling with expressionFitsOnRestOfLine.
dawedawe
changed the title
src/Fantomas.Tests/QuotationTests.fs
Outdated
| equal | ||
| """ | ||
| let action = | ||
| <@ let msg = %httpRequestMessageWithPayload |
There was a problem hiding this comment.
I can understand your reasoning behind the change.
However, this leads to the following problem.
I won't deny that there are other places where Fantomas has this problem.
The point is that there are different ways of looking at this.
If it is ok with you I'd like you to bring it up with the F# style guide over at https://github.com/fsharp/fslang-design#style-guide? That would be interesting for you to see that process as well.
Once there is an outcome there, it can be picked up in the style guide and we can respect the outcome in Fantomas.
There was a problem hiding this comment.
Sure. To speed things up it might be good to include a proposal in the raised issue.
So if I understand you correctly, you prefer to have <@/@> on separate lines for multi line expressions, right?
Given your example, I think there is a good argument for that.
There was a problem hiding this comment.
Yes, I prefer it mainly because of the technical impact on Fantomas side.
Things are more straightforward if we can keep a multitude of the indent_size.
But I don't have the strongest opinion as I've never really used a quotation before.
Fixes #2203
I used a slightly different fix to be more in line with what we do sofar.
Mainly to not put the
<@on separate lines.