Added SLNX and SLNF formats support and migrated to SLNX solution #723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the SLNX solution format by updating tests, migrating solution parsing to use Microsoft.Build.Construction.SolutionFile, removing the Ionide.ProjInfo.Sln dependency, and updating the changelog.
- Updated test cases to handle both .sln and .slnx files (absolute and relative paths).
- Modified solution parsing logic in Lint.fs to use SolutionFile.Parse with platform‐specific path adjustments.
- Removed the Ionide.ProjInfo.Sln package reference and cleaned up associated references.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/FSharpLint.FunctionalTest/TestApi.fs | Updated test cases to parameterize solution file names and expected warnings. |
| tests/FSharpLint.FunctionalTest.TestedProject/FSharpLint.FunctionalTest.TestedProject.slnx | Added a new SLNX format solution file. |
| src/FSharpLint.Core/FSharpLint.Core.fsproj | Removed the Ionide.ProjInfo.Sln dependency and added an embedded resource. |
| src/FSharpLint.Core/Application/Lint.fs | Replaced custom solution parsing with Microsoft.Build.Construction.SolutionFile.Parse and added exception handling. |
| FSharpLint.slnx | Added a new solution file in SLNX format. |
| FSharpLint.sln | Removed the old .sln file in favor of SLNX. |
| Directory.Packages.props | Removed package reference for Ionide.ProjInfo.Sln. |
| CHANGELOG.md | Updated changelog entries to reflect SLNX support and dependency removal. |
|
Nice |
|
Does need changing to add .slnx as well as .sln ? |
|
Yes, I've missed that... Thank you! |
|
@Numpsy pushed a commit |
|
An extra thought: Maybe .slnf files (solution filters) could be added as well? (That could be a separate change afterwards though) |
|
Great idea! |
xperiandri
force-pushed
the
slnx-support
branch
3 times, most recently
from
c2b69e8 to
29d7263
Compare
|
@Numpsy implemented |
xperiandri
changed the title
xperiandri
changed the title
xperiandri
added a commit
that referenced
this pull request
Jul 11, 2025
## [0.25.0] - 2025-07-11 - Migrate from `Paket` to `Directory.Packages.props` #722 [@xperiandri] - Migrate to .NET `9.0.201` and FCS `43.9.201` #722 [@xperiandri] - Write test logs to test context output #722 [@xperiandri] - Use string interpolation instead of `+` concatenation #724 [@xperiandri] - Run tests in parallel #728 [@xperiandri] - Remove `NoPartialFunctions` compiler workaround (#698) [@webwarrior-ws] - Add `SLNX` and `SLNF` format support and migrate to SLNX solution #723 [@xperiandri] Remove `Ionide.ProjInfo.Sln` NuGet package dependency - Remove `Newtonsoft.Json` NuGet dependency #725 [@xperiandri] - Add missing rule checks for FL0079-FL0081 #713 [@BennieCopeland] - Modify `.gitignore` to the Visual Studio standard one #735 [@xperiandri] - Add basic Copilot instructions and GitHub MCP #726 [@xperiandri] - Migrate `Fornax` to `0.16.0-beta002` and `FSharp.Formatting` to `20.0.1` #736 [@xperiandri, @Numpsy] - Update the build instructions to use `dotnet fsi` instead of `fake-cli` #734 [@Numpsy]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.