Skip to content

Added missing rule checks for FL0079-FL0081 #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 6, 2025

Conversation

BennieCopeland
Copy link
Contributor

Add missing rule checks for

  • UnnestedFunctionNames
  • NestedFunctionNames
  • SuggestUseAutoProperty

@knocte
Copy link
Collaborator

knocte commented Jul 16, 2024

Sorry again for the delay. Can you:

  • Rename commit msg to say "config hooks" instead of "checks".
  • Given that you have discovered that these rules were not actually working, can you then changed their docs to say correct version in the statement "introduced in vX.Y.Z"?
    Thanks!

@BennieCopeland
Copy link
Contributor Author

@knocte I made the requested changes.

@xperiandri xperiandri changed the title Add missing rule checks Added missing rule checks for FL0079-FL0081 Jul 6, 2025
@xperiandri xperiandri merged commit 0d2178d into fsprojects:master Jul 6, 2025
4 checks passed
@xperiandri
Copy link
Collaborator

Thank you very much for the contribution!

xperiandri pushed a commit that referenced this pull request Jul 6, 2025
* Add missing rule config hooks
* Update documentation with new version number
xperiandri added a commit that referenced this pull request Jul 11, 2025
## [0.25.0] - 2025-07-11

- Migrate from `Paket` to `Directory.Packages.props` #722 [@xperiandri]
- Migrate to .NET `9.0.201` and FCS `43.9.201` #722 [@xperiandri]
- Write test logs to test context output #722 [@xperiandri]
- Use string interpolation instead of `+` concatenation #724 [@xperiandri]
- Run tests in parallel #728 [@xperiandri]
- Remove `NoPartialFunctions` compiler workaround (#698) [@webwarrior-ws]
- Add `SLNX` and `SLNF` format support and migrate to SLNX solution #723 [@xperiandri]
  Remove `Ionide.ProjInfo.Sln` NuGet package dependency
- Remove `Newtonsoft.Json` NuGet dependency #725 [@xperiandri]
- Add missing rule checks for FL0079-FL0081 #713 [@BennieCopeland]
- Modify `.gitignore` to the Visual Studio standard one #735 [@xperiandri]
- Add basic Copilot instructions and GitHub MCP #726 [@xperiandri]
- Migrate `Fornax` to `0.16.0-beta002` and `FSharp.Formatting` to `20.0.1` #736 [@xperiandri, @Numpsy]
- Update the build instructions to use `dotnet fsi` instead of `fake-cli` #734 [@Numpsy]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants