Add key authentication #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
part:tooling
Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
ela-kotulska-frequenz
approved these changes
Jun 24, 2024
Comment on lines
177
to
+197
| def __init__( | ||
| self, microgrid_id: int, grpc_channel: grpc.aio.Channel, svc_addr: str | ||
| self, | ||
| *, | ||
| microgrid_id: int, | ||
| grpc_channel: grpc.aio.Channel, | ||
| svc_addr: str, | ||
| key: str, | ||
| ): | ||
| """Initialize the dispatcher. | ||
|
|
||
| Args: | ||
| microgrid_id: The microgrid id. | ||
| grpc_channel: The gRPC channel. | ||
| svc_addr: The service address. | ||
| key: The key to access the service. | ||
| """ | ||
| self._running_state_channel = Broadcast[Dispatch](name="running_state_change") | ||
| self._lifecycle_events_channel = Broadcast[DispatchEvent]( | ||
| name="lifecycle_events" | ||
| ) | ||
| self._client = Client(grpc_channel, svc_addr) | ||
| self._client = Client(grpc_channel=grpc_channel, svc_addr=svc_addr, key=key) |
There was a problem hiding this comment.
Looks good to me.
Just side note that 3 out of 4 arguments to Dispatcher constructor are really arguments to Client constructor.
And they are just passed to Client. And every description for these arguments is repeated in Client.
Maybe we could have single struct like ClientArgs in the future?
There was a problem hiding this comment.
That could work, though we want to change to the base-client where it will do this job for us
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update examples to use key and TLS