Implement key-based authentication #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Marenz
commented
Jun 13, 2024
Marenz
commented
- Add key-based authentication support
- Update REPL client to work better with host/port/key parameters
github-actions
bot
added
part:docs
llucax
reviewed
Jun 17, 2024
llucax
reviewed
Jun 18, 2024
Marenz
force-pushed
the
auth
branch
4 times, most recently
from
9b86795 to
3b4856a
Compare
llucax
previously approved these changes
Jun 19, 2024
Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
Before we couldn't really use "--host", "--port" and "--key" parameters with the REPL mode Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
Due to the new key parameter, we want to be more explicit Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
llucax
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.