Disable refresh #680
Merged
Disable refresh #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmol
previously approved these changes
Jan 7, 2020
There was a problem hiding this comment.
Works for me -- clicking the refresh icon results in one get_remote_data call, and further clicks while that's happening don't result in more invocations.
All the pointer state changes do nothing on Qubes, unfortunately, but that's a known problem.
We do seem to have the convention of starting boolean variable names with is_, but if this widget is going away, so will the inconsistency.
sssoleileraaa
force-pushed
the
disable_refresh
branch
from
c8a012f
to
2fcf916
Compare
sssoleileraaa
force-pushed
the
disable_refresh
branch
2 times, most recently
from
4c08a5f
to
d2af940
Compare
|
@rmol I rebased onto the wrong branch and it took me a few attempts to fix 🤕 Should be ready for another review now! |
sssoleileraaa
force-pushed
the
disable_refresh
branch
from
d2af940
to
078ff44
Compare
sssoleileraaa
force-pushed
the
disable_refresh
branch
from
078ff44
to
cec10f1
Compare
rmol
approved these changes
Jan 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #388
We're having discussions on removing the RefreshButton all together, so this fix is temporary - I just happened to be in this area of the code while consolidating load_toggle_icon with load_icon.
Test Plan