Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync icon should be disabled during active sync #388

Closed
redshiftzero opened this issue May 29, 2019 · 2 comments · Fixed by #680
Closed

Sync icon should be disabled during active sync #388

redshiftzero opened this issue May 29, 2019 · 2 comments · Fixed by #680
Labels
bug Something isn't working

Comments

@redshiftzero
Copy link
Contributor

Double clicks on the sync icon seem to be triggering double syncs. The first click on the sync icon should disable the sync icon, preventing subsequent clicks from causing syncs (@creviera flagged to me that this is complicated by the fact that the disabled state is now the offline icon). Then the existing logic in RefreshButton._on_refresh_complete should update the icon back to active when the sync has completed.

@eloquence
Copy link
Member

We discussed this briefly today. For the first iteration, we can keep the icon state as-is -- if the user clicks repeatedly, it'll still only add one job. We can revisit the use of a spinner or disabled state in future iterations.

@eloquence
Copy link
Member

We will likely want to move away from an interactive refresh icon, see #655 (comment) and discussion in #343. Leaving open until that work is fully specified, but removing from milestone/backlog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants