Skip to content

Conversation

@webbower
Copy link
Contributor

Move React deps into peerDependencies and devDependencies. Tested installing my branch in my project with this configuration and the conflicting React error is gone.

#40

@export-mike
Copy link

also got this is apart of react-15 update #44

@fraserxu fraserxu merged commit 6c2cf85 into fraserxu:master Apr 13, 2016
@fraserxu
Copy link
Owner

Close #44 and Thanks @webbower @export-mike 👍

@export-mike
Copy link

:) np

@export-mike
Copy link

Interesting, how come < 15.0.0 was chosen for react and react dom?

@fraserxu
Copy link
Owner

I just updated it to this as we haven't really change any of our code.

"peerDependencies": {
  "react": " "^0.14.7 || ^15.0.0-0"",
  "react-dom": " "^0.14.7 || ^15.0.0-0""
}

Same as this one fraserxu/react-chartist#36

@export-mike
Copy link

Great! :)

@webbower webbower deleted the fix-dependencies branch June 29, 2016 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants