Skip to content

Conversation

@joshgerdes
Copy link
Contributor

Initial testing with the charts I have in use (Line and Bar) seem to work fine with the upgrade. I have not fully tested with all chartist features.

@jcblw
Copy link

jcblw commented Apr 11, 2016

I have also confirmed with one of my projects that the pie/donut chart are functioning with react 15.

@fraserxu fraserxu merged commit a1b7e1a into fraserxu:master Apr 11, 2016
@joshgerdes
Copy link
Contributor Author

@fraserxu Could you please publish this minor update to npm when you get a chance? Thanks!

@fraserxu
Copy link
Owner

@joshgerdes @jcblw Something like v15.0.0?

@jcblw
Copy link

jcblw commented Apr 11, 2016

I would say just a patch like in the PR would be fine since nothing internally changed beside the peer dep. So v0.10.2

@fraserxu
Copy link
Owner

Hmm @jcblw , that makes sense. I'm suggesting v15.0.0 because that may indicate to user that this is following the version of React?

Yes, you are right, there's no changes in the code, the code could work for version other than v15.0.0.

@jcblw
Copy link

jcblw commented Apr 12, 2016

I would still say patch version is better its an easier update path for people looking to update to react 15.

Its npm update react-chartist rather then npm install react-chartist@15. Also libs like react-redux and react-dnd only updated there patch versions. I think the 15 version thing is mostly for the react-addon- stuff that facebook maintains.

@fraserxu
Copy link
Owner

I just updated the peerDependencies to

"peerDependencies": {
  "react": "^0.14.0 || ^15.0.0-0"
}

Following reduxjs/react-redux@da106bd

And published to v0.10.2, thanks @joshgerdes @jcblw

@jcblw
Copy link

jcblw commented Apr 12, 2016

no thank you @fraserxu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants