Validate URLs using Addressable gem to allow non-ascii characters (closes #111) #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warning: this allows a lot more URLs. See twingly/twingly-url#74 (comment)
goulvench
changed the title
goulvench
changed the title
goulvench
commented
Mar 19, 2022
| @@ -67,7 +82,7 @@ def build_ftp_record | |||
| describe "for invalid urls" do | |||
| it "rejects invalid urls" do | |||
| subject = build_url_record | |||
| subject.url = 'http://^^^^.fr' | |||
There was a problem hiding this comment.
http://^^^^.fr is considered valid by Addressable, which strictly adheres to the RFC. Spaces are not allowed though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning: this allows a lot more URLs.
There is not
valid?method onAddressable::URI, because many strings can be parsed and considered valid.See twingly/twingly-url#74 (comment)
This change requires a minor version bump, along with a bundle install warning I think.