Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All URLs containing non-ASCII characters are considered invalid #111

Open
goulvench opened this issue Feb 25, 2022 · 2 comments
Open

All URLs containing non-ASCII characters are considered invalid #111

goulvench opened this issue Feb 25, 2022 · 2 comments

Comments

@goulvench
Copy link

The current URL validation relies on URI.parse, from the standard library, which only works with ASCII.
The following valid URLs are therefore rejected: 'http://example.com/caractère-accentué', 'http://ουτοπία.δπθ.gr'.
The Addressable gem correctly parses these URLs, and could be used as a drop-in replacement instead.
Would you be interested in a PR?

@franckverrot
Copy link
Owner

Yes, makes total sense, thanks in advance 🙏🏽

@goulvench
Copy link
Author

Took a while because I've a lot on my plate but here it is: #112.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants