Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#18): add hooks to Serinus, remove guards and pipes #25

Merged
merged 13 commits into from
Jun 9, 2024

Conversation

francescovallone
Copy link
Owner

Description

Remove Guards and Pipes.
Add hooks system with local hooks and global hooks.
The hooks make the request lifecycle more accessible without reducing the performance.

Fixes #18

Type of change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

codecov bot commented Jun 9, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 30 lines in your changes missing coverage. Please review.

Project coverage is 87.01%. Comparing base (4404949) to head (7b69876).

Files Patch % Lines
...ages/serinus/lib/src/handlers/request_handler.dart 76.92% 6 Missing ⚠️
packages/serinus/lib/src/core/hook.dart 0.00% 5 Missing ⚠️
...ckages/serinus/lib/src/http/internal_response.dart 54.54% 5 Missing ⚠️
...ages/serinus/lib/src/contexts/request_context.dart 0.00% 4 Missing ⚠️
packages/serinus/lib/src/core/application.dart 0.00% 3 Missing ⚠️
...kages/serinus/lib/src/core/application_config.dart 0.00% 2 Missing ⚠️
...ackages/serinus/lib/src/http/internal_request.dart 83.33% 2 Missing ⚠️
packages/serinus/lib/src/handlers/handler.dart 85.71% 1 Missing ⚠️
packages/serinus/lib/src/http/request.dart 83.33% 1 Missing ⚠️
packages/serinus/lib/src/http/response.dart 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #25      +/-   ##
===========================================
- Coverage    87.12%   87.01%   -0.12%     
===========================================
  Files           70       65       -5     
  Lines         1989     1902      -87     
===========================================
- Hits          1733     1655      -78     
+ Misses         256      247       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@francescovallone francescovallone merged commit 8ba97a9 into develop Jun 9, 2024
1 of 3 checks passed
@francescovallone francescovallone deleted the feat/18 branch June 9, 2024 16:56
@francescovallone francescovallone changed the title Feat/18 feat(#18): add hooks to Serinus, remove guards and pipes Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant