Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#17): the file is now read as a stream and it is sent correctly to the user #20

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

francescovallone
Copy link
Owner

Description

The file is now read as a stream and it is sent correctly to the user

Fixes #17

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@francescovallone francescovallone linked an issue Jun 5, 2024 that may be closed by this pull request
@francescovallone francescovallone merged commit b981518 into develop Jun 5, 2024
1 check passed
@francescovallone francescovallone deleted the feat/17 branch June 5, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: Response.file should stream the file
1 participant