Skip to content

Restore commonjs sanity #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2021
Merged

Restore commonjs sanity #10

merged 1 commit into from
Jul 1, 2021

Conversation

amacneil
Copy link
Contributor

@amacneil amacneil commented Jul 1, 2021

Publishing modules as ESM is too bleeding edge in 2021. Most notably, even though node.js is perfectly happy to import ESM, jest spews out errors without additional configuration.

Maybe once jest properly supports ESM we can recommend this, but for now life is simpler for everyone if we publish commonjs.

@amacneil amacneil requested a review from jhurliman July 1, 2021 23:01
@amacneil amacneil merged commit 0e57965 into main Jul 1, 2021
@amacneil amacneil deleted the adrian/commonjs branch July 1, 2021 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant