Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Base Weapon" select on item sheets show the options for the current value of "Weapon Type" which can be from an Enchantment, rather than what the item is by default #4809

Open
krbz999 opened this issue Nov 30, 2024 · 0 comments · May be fixed by #4833
Open

"Base Weapon" select on item sheets show the options for the current value of "Weapon Type" which can be from an Enchantment, rather than what the item is by default #4809

krbz999 opened this issue Nov 30, 2024 · 0 comments · May be fixed by #4833
Assignees
@Fyorl
Labels
bug Functionality which is not working as intended
Milestone
D&D5E 4.2.0

Comments

@krbz999
Copy link
Contributor

krbz999 commented Nov 30, 2024

eg

weapon (simple ranged, shortbow)

enchantment sets system.type.value to martialR.

dropdown on sheet now shows only Martial Ranged options for base weapon.
@krbz999 krbz999 linked a pull request Dec 5, 2024 that will close this issue
Open
Fyorl added a commit that referenced this issue Dec 5, 2024
@Fyorl
[#4809] Fix base item choices when enchanted.
163ff38
@Fyorl Fyorl self-assigned this Dec 5, 2024
@Fyorl Fyorl added the bug Functionality which is not working as intended label Dec 5, 2024
@Fyorl Fyorl added this to the D&D5E 4.2.0 milestone Dec 5, 2024
Fyorl added a commit that referenced this issue Dec 11, 2024
@Fyorl
[#4809] Fix base item choices when enchanted.
b9da4b6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Fyorl Fyorl

Labels
bug Functionality which is not working as intended
Projects
None yet
Milestone
D&D5E 4.2.0
Development

Successfully merging a pull request may close this issue.

Improve consistency of Item Sheet display foundryvtt/dnd5e
2 participants
@Fyorl @krbz999