Improve consistency of Item Sheet display

[Fyorl]

• Closes Compendium-locked item properties are difficult to parse #4381
• Closes "Base Weapon" select on item sheets show the options for the current value of "Weapon Type" which can be from an Enchantment, rather than what the item is by default #4809
• Closes items Sheets not displaying updated properties after being enchanted #4364

This brings the Item sheet in-line with the V2 Actor sheet in terms of consistency around editability in Edit vs. Play mode. Form fields are now disabled in Play mode, and will now show any enchanted values, where before it was not possible to see them. Switching the sheet to edit mode will make the fields editable, with their source values displayed, avoiding the issue of potentially persisting enchantment-modified values, or making changes that do not visually update due to being enchantment-modified.

The sheets will now default to opening in Edit mode also, where appropriate, as most contexts where the Item sheet is opened imply editability (e.g. the right-click context menu on Actor sheets is labelled 'edit', and opening an Item from the sidebar is assumed for editing purposes). Contexts where the Item is not editable, such as a locked compendium, or when viewing an Item on an Actor with Observer permissions, the sheet will display in Play mode as Edit mode is not available in those contexts.

I've also improved a few areas of styling that were not displaying correctly in a disabled context.

[krbz999]

Probably closes #4809. :)

[Fyorl]

Probably closes #4809. :)

Well it would if I had known about that issue, but it at least provides a clear way to address it. I've pushed a fix for that now, and I imagine there will be a few other places where the source vs. enchantment-modified data is being mixed together that we will have to squash as we find them.

[krbz999]

mixed together that we will have to squash as we find them.

I took the liberty of doing a quick browse, and most fields are only contextually hidden, which should be fine. Only contender is the Area fieldset of a spell item, but I think it's gucci.

[arbron]

The sheets look good.

I have a concern about opening all sheets in edit mode particularly for classes/background/species items. Because they only have one description that means that people opening those sheets sees the item's raw description, rather than the enriched description. Could be fine I suppose.

[Fyorl]

I have a concern about opening all sheets in edit mode particularly for classes/background/species items. Because they only have one description that means that people opening those sheets sees the item's raw description, rather than the enriched description. Could be fine I suppose.

You are right, this probably needs some more thought. At the very least it should open in Edit mode if you are deliberately accessing it via the 'edit' context menu option. But there are a few other ways to view item sheets, in particular the ones you mentioned which can be opened with left-click directly from the actor sheet. I'm less certain of what the default should be when opening an item from the sidebar tab (or unlocked compendium).

[krbz999]

I'm less certain of what the default should be when opening an item from the sidebar tab (or unlocked compendium).

Having messed with similar in a different system, I more often than not ended up wanting Edit Mode primarily on these.

[Fyorl]

Item sheets will now open in Edit mode when explicitly choosing 'edit' in a context menu. Things like left-clicking the species item or left-clicking a container to view its contents will open in Play mode. Items in the sidebar and unlocked compendia will also open in Edit mode when opened.