-
Notifications
You must be signed in to change notification settings - Fork 239
Move non reverting execute to separate function #3756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 26, 2025
67f3e9e
to
15dfbc5
Compare
d1c0c59
to
8716bb9
Compare
8716bb9
to
987f209
Compare
15dfbc5
to
5ebc4f0
Compare
987f209
to
7b7b439
Compare
5ebc4f0
to
ab112e8
Compare
7b7b439
to
f48af4c
Compare
ab112e8
to
5031072
Compare
cptartur
reviewed
Sep 29, 2025
...heatnet/src/runtime_extensions/call_to_blockifier_runtime_extension/execution/entry_point.rs
Outdated
Show resolved
Hide resolved
...net/src/runtime_extensions/call_to_blockifier_runtime_extension/execution/execution_utils.rs
Outdated
Show resolved
Hide resolved
THenry14
reviewed
Sep 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the logic is ok from profiler pov 👍
ksew1
reviewed
Sep 29, 2025
...net/src/runtime_extensions/call_to_blockifier_runtime_extension/execution/execution_utils.rs
Show resolved
Hide resolved
5031072
to
7b9c9db
Compare
f48af4c
to
086e6ba
Compare
7b9c9db
to
61a12f8
Compare
086e6ba
to
df7f2ab
Compare
cptartur
approved these changes
Sep 29, 2025
ksew1
approved these changes
Sep 29, 2025
df7f2ab
to
ba49ade
Compare
27a94d8
to
2714ace
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 30, 2025
Related #3744 commit-id:fe6352de --- **Stack**: - #3756 - #3755 ⬅⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do not merge manually using the UI - doing so may have unexpected results.*
Related #3744 commit-id:5f0e42b9
2714ace
to
3d1b7ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #3744
commit-id:5f0e42b9