Skip to content

Save vm trace in trace data separately #3755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 30, 2025
Merged

Save vm trace in trace data separately #3755

merged 1 commit into from
Sep 30, 2025

Conversation

ddoktorski
Copy link
Contributor

@ddoktorski ddoktorski commented Sep 26, 2025 •
edited
Loading

Related #3744

commit-id:fe6352de

Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

@ddoktorski ddoktorski requested a review from a team as a code owner September 26, 2025 09:27
@ddoktorski ddoktorski requested review from MKowalski8 and cptartur and removed request for a team September 26, 2025 09:27
This was referenced Sep 26, 2025
Merged
Merged
Merged
Merged
github-merge-queue bot pushed a commit that referenced this pull request Sep 26, 2025
@ddoktorski
Get gas resources from CallInfo (#3736)
8774130 
Closes #3292
Closes #2960

commit-id:7967ca03

---

**Stack**:
- #3756
- #3755
- #3752
- #3751
- #3736 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
@ddoktorski ddoktorski requested review from THenry14 and ksew1 and removed request for MKowalski8 September 26, 2025 11:36
github-merge-queue bot pushed a commit that referenced this pull request Sep 26, 2025
@ddoktorski
Add test for get_available_gas (#3751)
17b213a 
Closes #3499

commit-id:c7694535

---

**Stack**:
- #3756
- #3755
- #3752
- #3751 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
@ddoktorski ddoktorski force-pushed the spr/master/fe6352de branch 2 times, most recently from 7b7b439 to f48af4c Compare September 26, 2025 13:56
cptartur
cptartur reviewed Sep 26, 2025
View reviewed changes
Copy link
Member

@cptartur cptartur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the benefit of doing it as a separate step?

@ddoktorski
Copy link
Contributor Author

What's the benefit of doing it as a separate step?

It enables changing the returned struct in the execute_entry_point_call_cairo1 function and as a result makes it possible to refactor execute_call_entry_point in the next PR

@ddoktorski ddoktorski requested a review from cptartur September 26, 2025 14:18
github-merge-queue bot pushed a commit that referenced this pull request Sep 29, 2025
@ddoktorski
Exclude syscall resources when building trace data to save (#3752)
bcfca70 
Closes #3399
Related #3744

commit-id:40786103

---

**Stack**:
- #3756
- #3755
- #3752 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
Base automatically changed from spr/master/40786103 to master September 29, 2025 15:49
@ddoktorski
Save vm trace in trace data separately
ba49ade 
Related #3744

commit-id:fe6352de
@ddoktorski ddoktorski added this pull request to the merge queue Sep 30, 2025
Merged via the queue into master with commit c9b4e3d Sep 30, 2025
26 checks passed
@ddoktorski ddoktorski deleted the spr/master/fe6352de branch September 30, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@THenry14 THenry14 THenry14 approved these changes

@cptartur cptartur cptartur approved these changes

@ksew1 ksew1 Awaiting requested review from ksew1

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ddoktorski @THenry14 @cptartur