Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump revm, accomodate new cancun struct changes #5858

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

Evalir
Copy link
Member

@Evalir Evalir commented Sep 20, 2023

Motivation

Right now cargo deny, clippy and other ci tests might fail because bluealloy/revm#724 was squashed and rebased against revm's master, which implements 4844, and the sha used doesn't exist anymore.

Solution

  • Updates revm to use the latest commit on the branch we're using
  • Accomodates the new TxEnv/BlockEnv fields by setting them to default. This should be non-consequential since we're not activating the cancun flag yet.
  • Accomodates the new EVMErrors fields by creating the corresponding tx/blockchain errors on anvil/evm. Should be non-consequential since we're not activating cancun yet.

Albeit both should be fine for current users, it might be the case that things might be misconfigured if ppl e.g solc team / uniswap team wants to test new opcodes @mattsse — so need to confirm if Defaults are okay (i'm referring to BlockEnv's excess_blob_gas, and TxEnv's max_fee_per_blob_gas specifically)

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm,

these are all fine since the additional settings are only necessary for eip-4844 transactions

@mattsse mattsse merged commit aeefc74 into master Sep 20, 2023
17 checks passed
@mattsse mattsse deleted the evalir/bump-revm-rebase branch September 20, 2023 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants