-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Reintroduce Alloy #724
Conversation
dd6fdf2
to
ff95074
Compare
You should be able to just |
oh yeah ik just hadn't done it—wanted to open the branch asap to leave the foundry drafts ready. Will do soon! |
If you have merged with |
3af3c66
to
c2c36fa
Compare
@Evalir failing CI blocking this
|
@gakonst we just need to rebase again—this test was also failing on main until today I see. |
e3be1cd
to
4dd6510
Compare
very nice - defer to dragan otherwise |
chore: remove hex, hex-literal dependencies
chore: remove unused dependencies
mind rebasing this? If we merge paradigmxyz/reth#4737 in reth, then reth won't have this fix: |
Opened Evalir#4 |
} | ||
|
||
pub fn caller<H: Host>(interpreter: &mut Interpreter, _host: &mut H) { | ||
gas!(interpreter, gas::BASE); | ||
push_b256!(interpreter, B256::from(interpreter.contract.caller)); | ||
push_b256!(interpreter, interpreter.contract.caller.into_word()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get the reference as in processor word (native type), but into_word
feels strange to me. Bikeshedding here, nothing to be changed in the essence, maybe into_evm_word
would be a more obvious name, but it does increase the fn name size.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 🎉
Including the Evalir#4. left a few nits (mostly like questions), Let us plan the merge on Monday (just to leave a few days for v3.4.0
to settle).
Merge branch 'main' into reintroduce-alloy-rebased
Rebases #617 to be up to date with the newest changes, mainly concerning bundlestate.