-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Debugger Refactor #1: fuzz single #5692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Evalir
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Loving how small this is. Some comments on docs and other things
wondering if it's possible to get a PR description on what exactly this is deduping? It's pretty clear if you read the code, but just for future reference
Also wondering, are these split PRs safe to be merged in any order or should we hold off?
|
Thanks @Evalir ! Adding a desc soon! |
Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com>
mattsse
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ty for breaking this up into smaller chunks!
some nits, otherwise lgtm
|
@iFrostizz sorry for the long review time—we've been setting up for travel and traveling over the past week so it's taken a tad more time to review things—let's get this in ASAP |
Evalir
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sweet, looks good. just a smol nit on docs
will defer to @mattsse for final approve / merge
|
@Evalir all good, and hope that you're all having fun there! |
|
Could we get rid of this use of |
|
@iFrostizz if it's not needed anymore, then sure! |
|
@Evalir could that be preferably done after the debugger refactor ? |
|
yep sounds good! @mattsse friendly ping |
Evalir
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aight sweet, sorry for taking so long with this one—let's send it and keep iterating
|
thanks @Evalir ! |
* fuzz single refactor * add struct docs * Update crates/evm/src/fuzz/mod.rs Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com> * add docs and move types to types.rs * fmt * add docki docs * fmt --------- Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com>
First part of #5547 breaking into smaller chunks.
This PR refactors the
fuzzfunction in order to have access to a more granular, single-step, function calledsingle_fuzz.It will let us in the context of the debugger to be able to run again the fuzzer on the last relevant (either a counter-example, or the first case, see the current imeplemtnation of the debugger launching https://github.com/foundry-rs/foundry/blob/master/crates/forge/bin/cmd/test/mod.rs#L209-L213 with this time debug traces (they are expensive, especially when fuzzed).