-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Refactoring of the debugger #5547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring of the debugger #5547
Conversation
|
heads up, we moved all crates to a crates folder, sorry about the inconvenience |
|
Seems good, need to add back support for fuzz testing (optimized debugger for fuzzing btw!!) |
|
Could also bundle breakpoints and debug_arena together as they are passed around a lot together |
|
@Evalir @mattsse any idea about This issue about the fuzzer please ? |
|
Should be gtg! Source mapping on |
|
@iFrostizz amazing! was just wondering—this ended up being quite big haha, and touches a few sensitive things—was wondering if it's possible to split the PR into several smaller ones? it's ok if they all merge to an specific branch, it's just a lot to review |
|
Yes, good idea @Evalir Sorry for that it was not planned at all but appeared to be necessary. I'll break that into multiple PRs, how much do you wanna review ideally ? +-500 lines ? |
|
yup around 500 lines is good (although if some parts are intertwined no biggy if one ends up being a tad bigger than that)! no worries—we're all guilty of big prs, this is great work! |
|
wondering @iFrostizz — is this closeable as this was split? |
|
Yep @Evalir , let's close! |
Motivation
Initial issue: we cannot use breakpoints when launching the debugger through
forge debugThis uncovered the fact that the debugger code is a bit confused.
For instance, when launching the debugger from
forge test, we had to instantiate aScriptArgsstruct, which is the struct we were instantiating withforge script --debug.Solution
Create a new struct
DebuggerArgsthat any part of the code should comply with in order to launch the debugger.Side effect:
goto breakpointdoes not work when the debugger is invoked withforge debug#5510