Skip to content

feat(lint): emit suggestions for named_struct_fields lint #11982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 6, 2025
Merged

feat(lint): emit suggestions for named_struct_fields lint #11982

merged 5 commits into from
Oct 6, 2025

Conversation

mablr
Copy link
Contributor

@mablr mablr commented Oct 6, 2025

Motivation

Follow-up of #11892 to close #11760 (last part about fix suggestion #11760 (comment))

Solution

  • Updated the named_struct_fields lint to emit suggestion for initializing structs with named fields.
  • Updated test data to reflect the new suggestion format in lint messages.

PR Checklist

  • Added Tests (updated existing one)
  • Added Documentation
  • Breaking changes

@mablr
feat(lint): enhance named struct fields lint with suggestions for aut…
d04d977 
…o-fix

- Updated the `NamedStructFields` lint to emit suggestions for initializing structs with named fields.
- Updated test data to reflect the new suggestion format in lint messages.
@mablr mablr marked this pull request as ready for review October 6, 2025 08:38
@onbjerg onbjerg self-assigned this Oct 6, 2025
onbjerg
onbjerg requested changes Oct 6, 2025
View reviewed changes
Copy link
Contributor

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's for completeness sake add an example in the test where the number of arguments does not match the struct definition. lint does parsing and lowering, but does not do typeck, so this should be fine.

onbjerg
onbjerg requested changes Oct 6, 2025
View reviewed changes
0xrusowsky
0xrusowsky previously requested changes Oct 6, 2025
View reviewed changes
onbjerg
onbjerg reviewed Oct 6, 2025
View reviewed changes
mablr and others added 2 commits October 6, 2025 13:34
@mablr @onbjerg
fix: field_name
a634312 
Co-authored-by: onbjerg <onbjerg@users.noreply.github.com>
@mablr
fix: previous suggestion, arg/field swap
2e82cb8 
- fmt
- fix missing ')'
@onbjerg onbjerg requested a review from 0xrusowsky October 6, 2025 11:43
@onbjerg onbjerg enabled auto-merge (squash) October 6, 2025 11:43
@onbjerg onbjerg merged commit 069d082 into foundry-rs:master Oct 6, 2025
16 checks passed
@github-project-automation github-project-automation bot moved this to Done in Foundry Oct 6, 2025
@jenpaff jenpaff moved this from Done to Completed in Foundry Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@onbjerg onbjerg onbjerg approved these changes

@0xrusowsky 0xrusowsky 0xrusowsky approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@grandizzy grandizzy Awaiting requested review from grandizzy grandizzy is a code owner

@yash-atreya yash-atreya Awaiting requested review from yash-atreya

@zerosnacks zerosnacks Awaiting requested review from zerosnacks zerosnacks is a code owner

Assignees

@onbjerg onbjerg

Labels

None yet

Projects

Foundry
Status: Completed

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat: lint to enforce declaring struct fields

3 participants

@mablr @onbjerg @0xrusowsky