feat: lint to enforce declaring struct fields

[0xClandestine]

Component

Forge

Describe the feature you would like

Add a lint that enforces explicit field naming when initializing structs, improving code readability and maintainability by requiring named parameters instead of positional arguments.

struct Person {
    string name;
    uint256 age;
    address wallet;
}

function namedArgs() public {
    Person memory person = Person({
        name: "Alice",
        age: 25,
        wallet: 0x123...
    });
}

function positionalArgs() public {
    Person memory person = Person("Alice", 25, 0x123...);
}

Additional context

No response

[0xClandestine]

May be a nice addition to #10907

[grandizzy]

@0xClandestine we're looking to make this a lint, would that work? thank you

[0xClandestine]

@0xClandestine we're looking to make this a lint, would that work? thank you

I think a lint could work (especially with auto-fix), however this feels more like a formatting issue since both approaches are equally valid, it's purely stylistic. Happy either way, just curious what the rationale is for lint over fmt?

A quick side note I forgot to mention: when using named fields, they don’t need to match the struct’s declaration order. However, for readability, the rule should probably enforce that order as well.

[DaniPopes]

The formatter doesn't know anything about the semantics of the program. It may be a purely visual change but it does require knowing where the struct constructors are and what struct they refer to, which is out of scope for a formatter which does not need this information otherwise.

[0xrusowsky]

impl guidance:

• follow the steps specified in https://github.com/foundry-rs/foundry/blob/master/docs/dev/lintrules.md#L1
• create a new struct for the lint and impl trait LateLintPass<'hir>
• check for ExprKind::Call expressions where the callee is a struct type ExprKind::Type + TypeKind::Custom
• if the call uses CallArgsKind::Unnamed emit the lint
• use the gcx to resolve the type and create the fix suggestion using the struct fields.

the lint should have informational severity