Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup the Makefile of unused and obsolete build targets #301

Merged
merged 3 commits into from
Oct 6, 2023
Merged

Cleanup the Makefile of unused and obsolete build targets #301

merged 3 commits into from
Oct 6, 2023

Commits on Oct 6, 2023

  1. Cleanup: remove fioctl-linux-armv7 from a list of supported platforms 

    It does not build in Golang 1.19 compiler and higher.
A correct way to specify the Arm version is via the GOARM environent variable.

Signed-off-by: Volodymyr Khoroz <volodymyr.khoroz@foundries.io>
    @vkhoroz
    vkhoroz committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    52046d1 View commit details
    Browse the repository at this point in the history

  2. Cleanup: remove the fioctl-static build target 

    All fioctl-% build targets are already static.
Moreover, this target is kind of misleading:
- It sets CGO_ENABLED=0 which forces to use internal linker.
- But, it then passes `extldflags` which are only relevant for external linker, i.e. they are ignored.

Anyway, it is redundant, so better get rid of it.

Signed-off-by: Volodymyr Khoroz <volodymyr.khoroz@foundries.io>
    @vkhoroz
    vkhoroz committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    997a6e0 View commit details
    Browse the repository at this point in the history

  3. Cleanup: remove the unused build docker image and related build targets 

    We never use it, meaning we never test it.

Signed-off-by: Volodymyr Khoroz <volodymyr.khoroz@foundries.io>
    @vkhoroz
    vkhoroz committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    7fc4703 View commit details
    Browse the repository at this point in the history